What about this one?
Its in a minor key now.
I got very confused after bar 5, so maybe there are mistakes there
Hi, Countrymath!
Here are some things that are wrong/could be better with your example; 4 part harmony can be very tricky, but don't get discouraged!
Generally speaking, you want to avoid leaps if possible. This is not a necessity as you will OFTEN times be forced to leap, but if it's at all possible to have a stepwise melody in the soprano, then do so; always watch for parallel fifths and octaves. For example: in the first three chords, notice the bass line. I-V6-I is a very typical opening progression for figured bass harmony, and it's a perfect example on proper voice leading. G down to F# back up to G - stepwise motion. So it's best that the soprano mimics this in contrary motion. Ex. G up to A back down to G.
First beat, 3rd measure - your chord is incorrect. A iv6 in g minor is a c minor/E flat, however you have a B flat in the tenor. You can't move the tenor D in the third beat of measure 2 up to E flat or down to to C because you will have parallel octaves. V to iv6 is a very weak progression in any key, but I don't know how much theory you've learned, so if you haven't learned any other chord that would work better with an E flat in the bass, find a way to make the iv6 work.
It's always best to keep the soprano moving unless you have some really interesting chord progressions. You won't get to those for awhile, so always try to keep the soprano in motion (contrary motion is always best and that will avoid the majority of parallel 5ths and octaves).
First beat 6th measure, even if you have the leading tone as both the alto and tenor, it is still considered doubling the leading tone and is a major no-no. On top of that, the F sharp in the tenor is resolving down to an E flat which is an Augmented 2nd interval; that is an example of poor voice leading and it will sound terrible. As a side note, if your leading tone is in an inner voice (alto or tenor) it does not have to resolve up to the G.
Though it is perfectly acceptable for your final cadence to end on the 3rd of the tonic chord, if it's possible to end on the tonic itself, then do that instead. It's much more powerful of a cadence.
I hope this helps and I hope I didn't confuse you any further. Please feel free to ask more questions if you don't understand something. Also, if someone ever disagrees with anything I say, I openly welcome debates!
